Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass username to quoted message #9076

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Pass username to quoted message #9076

merged 1 commit into from
Oct 1, 2019

Conversation

cammellos
Copy link
Contributor

Fixes: #9071

status: ready

@cammellos cammellos requested a review from a team as a code owner September 30, 2019 11:34
@cammellos cammellos self-assigned this Sep 30, 2019
@auto-assign auto-assign bot removed the request for review from a team September 30, 2019 11:34
@status-github-bot
Copy link

status-github-bot bot commented Sep 30, 2019 •
edited by cammellos
Loading

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Sep 30, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (18)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c1450d4 #1 2019-09-30 11:44:57 ~10 min ios 📦ipa 📲
✔️ c1450d4 #1 2019-09-30 11:47:48 ~12 min linux 📦App
✔️ c1450d4 #1 2019-09-30 11:48:54 ~13 min windows 📦exe
✔️ c1450d4 #1 2019-09-30 11:48:54 ~13 min macos 📦dmg
✔️ c1450d4 #1 2019-09-30 11:53:49 ~18 min android-e2e 📦apk 📲
✔️ c1450d4 #1 2019-09-30 11:53:51 ~18 min android 📦apk 📲
✔️ d76256d #2 2019-09-30 13:55:20 ~9 min ios 📦ipa 📲
✔️ d76256d #2 2019-09-30 13:58:52 ~13 min macos 📦dmg
✔️ d76256d #2 2019-09-30 13:58:52 ~13 min linux 📦App
✔️ d76256d #2 2019-09-30 13:58:59 ~13 min windows 📦exe
✔️ d76256d #2 2019-09-30 13:59:14 ~13 min android-e2e 📦apk 📲
❌ d76256d #2 2019-09-30 13:59:22 ~13 min android 📄log
❌ 611568b #3 2019-10-01 07:08:24 ~3 min ios 📄log
✔️ 611568b #3 2019-10-01 07:16:44 ~11 min macos 📦dmg
✔️ 611568b #3 2019-10-01 07:16:51 ~11 min linux 📦App
✔️ 611568b #3 2019-10-01 07:17:41 ~12 min windows 📦exe
❌ 611568b #3 2019-10-01 07:20:31 ~15 min android-e2e 📄log
❌ 611568b #3 2019-10-01 07:20:55 ~16 min android 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 6d5c02b #4 2019-10-01 07:47:51 ~3 min ios 📄log
✔️ 6d5c02b #4 2019-10-01 07:56:17 ~11 min macos 📦dmg
✔️ 6d5c02b #4 2019-10-01 07:56:29 ~12 min android 📦apk 📲
✔️ 6d5c02b #4 2019-10-01 07:57:10 ~12 min linux 📦App
✔️ 6d5c02b #4 2019-10-01 07:57:21 ~12 min windows 📦exe
✔️ 6d5c02b #4 2019-10-01 07:57:37 ~13 min android-e2e 📦apk 📲
✔️ 6d5c02b #5 2019-10-01 09:38:12 ~10 min ios 📦ipa 📲
❌ 0769c35 #5 2019-10-01 09:49:40 ~9 min macos 📄log
❌ 0769c35 #5 2019-10-01 09:52:21 ~11 min linux 📄log
❌ 0769c35 #5 2019-10-01 09:52:44 ~12 min windows 📄log
✔️ 0769c35 #6 2019-10-01 09:55:13 ~14 min ios 📦ipa 📲
✔️ 0769c35 #5 2019-10-01 10:01:50 ~21 min android 📦apk 📲
✔️ 0769c35 #5 2019-10-01 10:02:21 ~21 min android-e2e 📦apk 📲

yenda
yenda previously requested changes Sep 30, 2019
View reviewed changes
src/status_im/ui/screens/chat/utils.cljs Outdated Show resolved Hide resolved
yenda
yenda reviewed Sep 30, 2019
View reviewed changes
Copy link
Contributor

@yenda yenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. not tested

@cammellos
Copy link
Contributor Author

@yenda fixed, could you re-review please?

@yenda yenda dismissed their stale review September 30, 2019 13:52

code was changed

@statustestbot
Copy link

89% of end-end tests have passed

Total executed tests: 47
Failed tests: 5
Passed tests: 42

Failed tests (5)

Click to expand
1. test_send_transaction_from_daap

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Balance is not changed during 360 seconds, funds were not received!

Device sessions

2. test_send_token_with_7_decimals

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.0333531 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

3. test_modify_transaction_fee_values

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.003017417 is not found in list of transactions, address is b92496fffd668c2de08694623303456aa98cdf33

Device sessions

4. test_send_eth_from_wallet_to_address

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.003017413 is not found in list of transactions, address is 9164f86170290ba3080e37d19d1953d3c5945913

Device sessions

5. test_send_stt_from_wallet

Device 1: Wait for OkButton
Device 1: Tap on OkButton

Transaction with amount 0.0030174159 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

Passed tests (42)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_deploy_contract_from_daap
Device sessions

5. test_open_transaction_on_etherscan
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_long_press_to_delete_1_1_chat
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_ens_in_public_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_offline_messaging_1_1_chat
Device sessions

18. test_add_account_to_multiaccount_instance
Device sessions

19. test_manage_assets
Device sessions

20. test_long_press_to_delete_public_chat
Device sessions

21. test_send_emoji
Device sessions

22. test_search_chat_on_home
Device sessions

23. test_logcat_recovering_account
Device sessions

24. test_can_add_existing_ens
Device sessions

25. test_messaging_in_different_networks
Device sessions

26. test_logcat_backup_recovery_phrase
Device sessions

27. test_logcat_sign_message_from_daap
Device sessions

28. test_switch_users_and_add_new_account
Device sessions

29. test_login_with_new_account
Device sessions

30. test_start_chat_with_ens
Device sessions

31. test_add_contact_from_public_chat
Device sessions

32. test_send_two_transactions_one_after_another_in_dapp
Device sessions

33. test_password_in_logcat_creating_account
Device sessions

34. test_backup_recovery_phrase
Device sessions

35. test_offline_status
Device sessions

36. test_open_google_com_via_open_dapp
Device sessions

37. test_unread_messages_counter_public_chat
Device sessions

38. test_sign_message_from_daap
Device sessions

39. test_user_can_remove_profile_picture
Device sessions

40. test_share_contact_code_and_wallet_address
Device sessions

41. test_refresh_button_browsing_app_webview
Device sessions

42. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@cammellos
Copy link
Contributor Author

@churik @Serhy I don't think the e2e tests are related, could you have a look please? Thanks!

@churik
Copy link
Member

churik commented Oct 1, 2019 •
edited
Loading

@cammellos not related, due to stuck transaction on "Pending" state on chain.
If you tested can merge. I'll create new e2e for replies after merge (it is not covered)

@cammellos
Copy link
Contributor Author

@jakubgs I can build this anymore:

`[2019-10-01T07:20:50.403Z] + cp result/app.apk StatusIm-191001-070454-611568-pr.apk

[2019-10-01T07:20:50.403Z] cp: cannot stat 'result/app.apk': No such file or directory

script returned exit code 1`

could you please have a look?
Thanks

@yenda
Copy link
Contributor

yenda commented Oct 1, 2019

@cammellos did you rebase already? because yesterday the apk splitting PR was merged

@cammellos
Copy link
Contributor Author

@yenda that might be it, let me try

@cammellos cammellos force-pushed the bug/#9071 branch 3 times, most recently from 0769c35 to 42961f3 Compare October 1, 2019 10:13
@cammellos
Add username to quoted message
42961f3 
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
@cammellos cammellos merged commit 42961f3 into develop Oct 1, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@jakubgs jakubgs deleted the bug/#9071 branch May 12, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda left review comments

@hesterbruikman hesterbruikman hesterbruikman left review comments

@flexsurfer flexsurfer flexsurfer approved these changes

@vkjr vkjr Awaiting requested review from vkjr

Assignees

@cammellos cammellos

Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quoted messages (replies) contains chat key instead of generated name
7 participants
@cammellos @status-im-auto @statustestbot @churik @yenda @flexsurfer @hesterbruikman